linux-kernel - Re: [PATCH linux-next] eeprom: at24:using the pm_runtime_resume_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 Aug 2022 08:22:16 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     cgel.zte@...il.com
Cc:     linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] eeprom: at24:using the
 pm_runtime_resume_and_get to  simplify the code

On Wed, Aug 03, 2022 at 06:16:18AM +0000, cgel.zte@...il.com wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> Using pm_runtime_resume_and_get() to instade of  pm_runtime_get_sync
> and pm_runtime_put_noidle.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
>  drivers/misc/eeprom/at24.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> index 633e1cf08d6e..f354b79619d8 100644
> --- a/drivers/misc/eeprom/at24.c
> +++ b/drivers/misc/eeprom/at24.c
> @@ -431,9 +431,8 @@ static int at24_read(void *priv, unsigned int off, void *val, size_t count)
>  	if (off + count > at24->byte_len)
>  		return -EINVAL;
>  
> -	ret = pm_runtime_get_sync(dev);
> +	ret = pm_runtime_resume_and_get(dev);
>  	if (ret < 0) {
> -		pm_runtime_put_noidle(dev);
>  		return ret;
>  	}
>  
> @@ -478,9 +477,8 @@ static int at24_write(void *priv, unsigned int off, void *val, size_t count)
>  	if (off + count > at24->byte_len)
>  		return -EINVAL;
>  
> -	ret = pm_runtime_get_sync(dev);
> +	ret = pm_runtime_resume_and_get(dev);
>  	if (ret < 0) {
> -		pm_runtime_put_noidle(dev);
>  		return ret;
>  	}
>  
> -- 
> 2.25.1

Again, please read:
	https://lore.kernel.org/r/YujeLEMsIrVD2tGn@kroah.com