linux-kernel - Re: [PATCH v2 4/4] drivers: misc: Add Support for TMR Inject IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee2f6680-5dbf-665f-a5aa-d607262c3365@amd.com>
Date:   Wed, 3 Aug 2022 12:05:46 +0530
From:   "Rao, Appana Durga Kedareswara" <appanad@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     Appana Durga Kedareswara rao 
        <appana.durga.kedareswara.rao@....com>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <michal.simek@...inx.com>,
        <derek.kiernan@...inx.com>, <dragan.cvetic@...inx.com>,
        <arnd@...db.de>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <git@....com>,
        <git@...inx.com>,
        Appana Durga Kedareswara rao <appana.durga.rao@...inx.com>
Subject: Re: [PATCH v2 4/4] drivers: misc: Add Support for TMR Inject IP

Hi Greg,

On 29/07/22 2:32 pm, Greg KH wrote:
> On Fri, Jul 29, 2022 at 01:43:47PM +0530, Rao, Appana Durga Kedareswara wrote:
>> Hi Greg,
>>
>> Thanks for the review.
>>
>> On 28/07/22 7:54 pm, Greg KH wrote:
>>> On Wed, Jul 20, 2022 at 11:30:16AM +0530, Appana Durga Kedareswara rao wrote:
>>>> From: Appana Durga Kedareswara rao <appana.durga.rao@...inx.com>
>>>>
>>>> The Triple Modular Redundancy(TMR) provides functional fault injection by
>>>> changing selected MicroBlaze instructions, which provides the possibility
>>>> to verify that the TMR subsystem error detection and fault recovery logic
>>>> is working properly, provided sysfs entries which allow the user to inject
>>>> a fault.
>>>
>>> We already have a fault-injection api, why are you not using that?
>>>
>>
>> Inorder to inject the error using TMR inject IP, The API
>> which injects the error should be executed from Processor LMB,
>> below sysfs entry calls microblaze core API xmb_inject_err()
>> which switches the processor to real mode and injects the error,
>> Please find the code corresponds to xmb_inject_err() API here:
>> https://www.spinics.net/lists/arm-kernel/msg991888.html
> 
> You did not answer the question.  Why are you not using the in-kernel
> fault injection userspace api and why have you created your own?

will update the driver to use fault injection user space API in next 
version.

> 
> Also, please use lore.kernel.org links when possible.

Sure

Regards,
Kedar.
> 
> thanks,
> 
> greg k-h