linux-kernel - Re: drivers/irqchip/irq-loongson-eiointc.c:289:20: warning: no previous prototype for 'acpi_get_vec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87pmhhbxdi.wl-maz@kernel.org>
Date:   Wed, 03 Aug 2022 08:27:05 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     kernel test robot <lkp@...el.com>,
        Huacai Chen <chenhuacai@...ngson.cn>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Jianmin Lv <lvjianmin@...ngson.cn>
Subject: Re: drivers/irqchip/irq-loongson-eiointc.c:289:20: warning: no previous prototype for 'acpi_get_vec_parent'

On Wed, 03 Aug 2022 00:02:04 +0100,
kernel test robot <lkp@...el.com> wrote:
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   c1dbe9a1c86da098a29dcdca1a67b65e2de7ec3a
> commit: dd281e1a1a937ee2f13bd0db5be78e5f5b811ca7 irqchip: Add Loongson Extended I/O interrupt controller support
> date:   2 weeks ago
> config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20220803/202208030600.u3ehRjUE-lkp@intel.com/config)
> compiler: loongarch64-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dd281e1a1a937ee2f13bd0db5be78e5f5b811ca7
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout dd281e1a1a937ee2f13bd0db5be78e5f5b811ca7
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/irqchip/ drivers/platform/surface/aggregator/
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/irqchip/irq-loongson-eiointc.c:289:20: warning: no previous prototype for 'acpi_get_vec_parent' [-Wmissing-prototypes]
>      289 | struct irq_domain *acpi_get_vec_parent(int node, struct acpi_vector_group *vec_group)
>          |                    ^~~~~~~~~~~~~~~~~~~
> 
> 
> vim +/acpi_get_vec_parent +289 drivers/irqchip/irq-loongson-eiointc.c
> 
>    288	
>  > 289	struct irq_domain *acpi_get_vec_parent(int node, struct acpi_vector_group *vec_group)
>    290	{
>    291		int i;
>    292	
>    293		for (i = 0; i < MAX_IO_PICS; i++) {
>    294			if (node == vec_group[i].node)
>    295				return vec_group[i].parent;
>    296		}
>    297		return NULL;
>    298	}
>    299	

Huacan, Jiamin,

There is a bunch of these failures:

- 202208021528.FiUMZ8BX-lkp@...el.com
- 202208021521.Z3FSeLUl-lkp@...el.com
- 202208022031.9hRlPwUl-lkp@...el.com
- 202208020817.G8vpKIfp-lkp@...el.com

Please investigate them, as LoongArch is so far the largest offender
in the irqchip tree.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.