linux-kernel - RE: [PATCH] thunderbolt: Supporting wake on DP hot events behind TBT/USB4 routers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB48354DBE206824F26EB3D830969C9@CO1PR11MB4835.namprd11.prod.outlook.com>
Date:   Wed, 3 Aug 2022 07:31:30 +0000
From:   "Khandelwal, Rajat" <rajat.khandelwal@...el.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        "Malani, Prashant" <pmalani@...gle.com>,
        "bleung@...gle.com" <bleung@...gle.com>
CC:     "andreas.noever@...il.com" <andreas.noever@...il.com>,
        "Jamet, Michael" <michael.jamet@...el.com>,
        "YehezkelShB@...il.com" <YehezkelShB@...il.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Rao, Abhijeet" <abhijeet.rao@...el.com>
Subject: RE: [PATCH] thunderbolt: Supporting wake on DP hot events behind
 TBT/USB4 routers



-----Original Message-----
From: Khandelwal, Rajat 
Sent: Wednesday, August 3, 2022 1:00 PM
To: Mika Westerberg <mika.westerberg@...ux.intel.com>; Malani, Prashant <pmalani@...gle.com>; bleung@...gle.com
Cc: andreas.noever@...il.com; Jamet, Michael <michael.jamet@...el.com>; YehezkelShB@...il.com; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org; Rao, Abhijeet <abhijeet.rao@...el.com>
Subject: RE: [PATCH] thunderbolt: Supporting wake on DP hot events behind TBT/USB4 routers

+Abhijeet
@Benson Leung @Malani, Prashant Please provide your comments. 

-----Original Message-----
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
Sent: Wednesday, August 3, 2022 11:07 AM
To: Khandelwal, Rajat <rajat.khandelwal@...el.com>
Cc: andreas.noever@...il.com; Jamet, Michael <michael.jamet@...el.com>; YehezkelShB@...il.com; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org; Malani, Prashant <pmalani@...gle.com>; bleung@...gle.com
Subject: Re: [PATCH] thunderbolt: Supporting wake on DP hot events behind TBT/USB4 routers

Hi,

On Wed, Aug 03, 2022 at 06:31:39AM +0530, Rajat Khandelwal wrote:
> Current implementation doesn't allow user to go into system suspend 
> and simultaneously project the screen on an external display connected 
> to a TBT/USB4 device. This patch enables this feature.
> 
> Let me know what you think about this.

Please prefix patches to follow the sybsystem style. For Thunderbolt it should be "thunderbolt: ....".

This will cause any monitor plug to wake up the system and I'm not sure we want that, at least to be default behaviour. If you have a regular Type-C (non-USB4/TBT) dock and you plug in a monitor to that, does it wake up?

IIRC I already suggested you to do this for the USB4 ports themselves (struct usb4_port) so that userspace can make them wake up the system on any event by writing "enabled > .../wakeup" which is the normal way.

Download attachment "0001-Supporting-wake-on-DP-hot-events-behind-TBT-USB4-rou.patch" of type "application/octet-stream" (2629 bytes)