lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 3 Aug 2022 10:48:18 +0200 From: Ingo Molnar <mingo@...nel.org> To: Siddh Raman Pant <code@...dh.me> Cc: x86 <x86@...nel.org>, Dave Hansen <dave.hansen@...ux.intel.com>, Andy Lutomirski <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>, linux-kernel <linux-kernel@...r.kernel.org>, linux-kernel-mentees <linux-kernel-mentees@...ts.linuxfoundation.org> Subject: Re: [PATCH] x86/numa: Use cpumask_available instead of hardcoded NULL check * Siddh Raman Pant <code@...dh.me> wrote: > On Tue, 02 Aug 2022 16:37:44 +0530 Ingo Molnar <mingo@...nel.org> wrote: > > Your fix makes sense I suppose, but I'm wondering how testing didn't > > trigger this warning. > > > > Off-stack isn't a rare config option: > > > > kepler:~/tip> make allmodconfig > > # > > # No change to .config > > # > > kepler:~/tip> grep CPUMASK_OFFSTACK .config > > CONFIG_CPUMASK_OFFSTACK=y > > kepler:~/tip> > > > > What am I missing? > > Maybe this triggers on certain config options set, or maybe due to new > gcc version? (I'm using gcc-12, I also likely saw while on gcc-11.) > It nevertheless is a helpful warning. > > I just now tried `make defconfig` (default configuration based on > 'x86_64_defconfig') and compiling with `make -j13 all`, and gcc doesn't > give any warning. (CONFIG_CPUMASK_OFFSTACK isn't even listed in the > .config file produced, grep fails.) Does 'allmodconfig' reproduce the warning for you: $ make allmodconfig $ make arch/x86/mm/numa.o ? If yes, then this could be due to gcc-12, as it doesn't reproduce with gcc-11 for me: gcc version 11.2.0 (Ubuntu 11.2.0-19ubuntu1) Thanks, Ingo
Powered by blists - more mailing lists