linux-kernel - Re: [PATCH v1] pinctrl: qcom: sm8250: Fix PDC map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38d82563-12dd-3d74-efb7-7066c114f016@somainline.org>
Date:   Wed, 3 Aug 2022 17:53:27 +0200
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Jianhua Lu <lujianhua000@...il.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] pinctrl: qcom: sm8250: Fix PDC map



On 3.08.2022 03:56, Jianhua Lu wrote:
> Fix the PDC mapping for SM8250, gpio39 is mapped to irq73(not irq37).
> 
> Fixes: b41efeed507a("pinctrl: qcom: sm8250: Specify PDC map.")
> Signed-off-by: Jianhua Lu <lujianhua000@...il.com>
> ---
> 
> Changes in v1:
Acutally, it should be v2 as the first send is assumed to be a v1.
> - fixes typo error(mapped target is irq, not gpio).
> 

The change looks in line with msm-4.19 though.

Reviewed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>

Konrad
>  drivers/pinctrl/qcom/pinctrl-sm8250.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250.c b/drivers/pinctrl/qcom/pinctrl-sm8250.c
> index af144e724bd9..3bd7f9fedcc3 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sm8250.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sm8250.c
> @@ -1316,7 +1316,7 @@ static const struct msm_pingroup sm8250_groups[] = {
>  static const struct msm_gpio_wakeirq_map sm8250_pdc_map[] = {
>  	{ 0, 79 }, { 1, 84 }, { 2, 80 }, { 3, 82 }, { 4, 107 }, { 7, 43 },
>  	{ 11, 42 }, { 14, 44 }, { 15, 52 }, { 19, 67 }, { 23, 68 }, { 24, 105 },
> -	{ 27, 92 }, { 28, 106 }, { 31, 69 }, { 35, 70 }, { 39, 37 },
> +	{ 27, 92 }, { 28, 106 }, { 31, 69 }, { 35, 70 }, { 39, 73 },
>  	{ 40, 108 }, { 43, 71 }, { 45, 72 }, { 47, 83 }, { 51, 74 }, { 55, 77 },
>  	{ 59, 78 }, { 63, 75 }, { 64, 81 }, { 65, 87 }, { 66, 88 }, { 67, 89 },
>  	{ 68, 54 }, { 70, 85 }, { 77, 46 }, { 80, 90 }, { 81, 91 }, { 83, 97 },