lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 3 Aug 2022 10:38:26 -0700 From: Bart Van Assche <bvanassche@....org> To: j-young.choi@...sung.com, ALIM AKHTAR <alim.akhtar@...sung.com>, "avri.altman@....com" <avri.altman@....com>, "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>, "martin.petersen@...cle.com" <martin.petersen@...cle.com>, "beanhuo@...ron.com" <beanhuo@...ron.com>, "adrian.hunter@...el.com" <adrian.hunter@...el.com>, "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "stanley.chu@...iatek.com" <stanley.chu@...iatek.com> Subject: Re: [PATCH v6 3/6] scsi: ufs: wb: Add explicit flush sysfs attribute On 8/2/22 01:07, Jinyoung CHOI wrote: > +What: /sys/bus/platform/drivers/ufshcd/*/wb_buf_flush_en > +What: /sys/bus/platform/devices/*.ufs/wb_buf_flush_en > +Date: July 2022 > +Contact: Jinyoung Choi <j-young.choi@...sung.com> > +Description: This entry shows the status of WriteBooster buffer flushing Can we rename this attribute into something that has a word order that is grammatically correct, e.g. enable_wb_buf_flush? > + and it can be used to allow or disallow the flushing. > + If the flushing is allowed, the device executes the flush > + operation when the command queue is empty. The attribute has "enabled" in its name while the above text uses the verb "allowed". Consider changing "allowed" into "enabled". Please also change "If the flushing" into "If flushing". Thanks, Bart.
Powered by blists - more mailing lists