linux-kernel - Re: [PATCH] drm/virtio: remove drm_plane

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yuq+63QAyOYQvbvX@ravnborg.org>
Date:   Wed, 3 Aug 2022 20:31:07 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Danilo Krummrich <dakr@...hat.com>
Cc:     airlied@...ux.ie, daniel@...ll.ch, kraxel@...hat.com,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/virtio: remove drm_plane_cleanup() destroy hook

Hi Danilo,

On Wed, Aug 03, 2022 at 04:55:20PM +0200, Danilo Krummrich wrote:
> drmm_universal_plane_alloc() already registers drm_plane_cleanup() as
> managed release action via drmm_add_action_or_reset(). Hence,
> drm_plane_cleanup() should not be set as drm_plane_funcs.destroy hook.
> 
> Fixes: 7847628862a8 ("drm/virtio: plane: use drm managed resources")
> Signed-off-by: Danilo Krummrich <dakr@...hat.com>
Reviewed-by: Sam Ravnborg <sam@...nborg.org>
> ---
>  drivers/gpu/drm/virtio/virtgpu_plane.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
> index c599c99f228e..4c09e313bebc 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_plane.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
> @@ -69,7 +69,6 @@ uint32_t virtio_gpu_translate_format(uint32_t drm_fourcc)
>  static const struct drm_plane_funcs virtio_gpu_plane_funcs = {
>  	.update_plane		= drm_atomic_helper_update_plane,
>  	.disable_plane		= drm_atomic_helper_disable_plane,
> -	.destroy		= drm_plane_cleanup,
>  	.reset			= drm_atomic_helper_plane_reset,
>  	.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
>  	.atomic_destroy_state	= drm_atomic_helper_plane_destroy_state,
> -- 
> 2.37.1