lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 3 Aug 2022 22:26:51 +0200 From: Borislav Petkov <bp@...en8.de> To: "Kalra, Ashish" <Ashish.Kalra@....com> Cc: "x86@...nel.org" <x86@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "linux-coco@...ts.linux.dev" <linux-coco@...ts.linux.dev>, "linux-mm@...ck.org" <linux-mm@...ck.org>, "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>, "tglx@...utronix.de" <tglx@...utronix.de>, "mingo@...hat.com" <mingo@...hat.com>, "jroedel@...e.de" <jroedel@...e.de>, "Lendacky, Thomas" <Thomas.Lendacky@....com>, "hpa@...or.com" <hpa@...or.com>, "ardb@...nel.org" <ardb@...nel.org>, "pbonzini@...hat.com" <pbonzini@...hat.com>, "seanjc@...gle.com" <seanjc@...gle.com>, "vkuznets@...hat.com" <vkuznets@...hat.com>, "jmattson@...gle.com" <jmattson@...gle.com>, "luto@...nel.org" <luto@...nel.org>, "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>, "slp@...hat.com" <slp@...hat.com>, "pgonda@...gle.com" <pgonda@...gle.com>, "peterz@...radead.org" <peterz@...radead.org>, "srinivas.pandruvada@...ux.intel.com" <srinivas.pandruvada@...ux.intel.com>, "rientjes@...gle.com" <rientjes@...gle.com>, "dovmurik@...ux.ibm.com" <dovmurik@...ux.ibm.com>, "tobin@....com" <tobin@....com>, "Roth, Michael" <Michael.Roth@....com>, "vbabka@...e.cz" <vbabka@...e.cz>, "kirill@...temov.name" <kirill@...temov.name>, "ak@...ux.intel.com" <ak@...ux.intel.com>, "tony.luck@...el.com" <tony.luck@...el.com>, "marcorr@...gle.com" <marcorr@...gle.com>, "sathyanarayanan.kuppuswamy@...ux.intel.com" <sathyanarayanan.kuppuswamy@...ux.intel.com>, "alpergun@...gle.com" <alpergun@...gle.com>, "dgilbert@...hat.com" <dgilbert@...hat.com>, "jarkko@...nel.org" <jarkko@...nel.org> Subject: Re: [PATCH Part2 v6 06/49] x86/sev: Add helper functions for RMPUPDATE and PSMASH instruction On Mon, Aug 01, 2022 at 10:31:26PM +0000, Kalra, Ashish wrote: > The struct rmpentry is the raw layout of the RMP table entry > while struct rmpupdate is the structure expected by the rmpupdate > instruction for programming the RMP table entries. > > Arguably, we can program a struct rmpupdate internally from a struct > rmpentry. > > But we will still need struct rmpupdate for issuing the rmpupdate > instruction, so it is probably cleaner to keep it this way, as it only > has two main callers - rmp_make_private() and rmp_make_shared(). Ok, but then call it struct rmp_state. The APM says in the RMPUPDATE blurb: "The RCX register provides the effective address of a 16-byte data structure which contains the new RMP state." so the function signature should be: static int rmpupdate(u64 pfn, struct rmp_state *new) and this is basically the description of that. It can't get any more user-friendly than this. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
Powered by blists - more mailing lists