linux-kernel - Re: [PATCH 2/8] dt-bindings: remoteproc: qcom: adsp: Add compatible name for SC7280

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220803204359.GA2586715-robh@kernel.org>
Date:   Wed, 3 Aug 2022 14:43:59 -0600
From:   Rob Herring <robh@...nel.org>
To:     Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
Cc:     linux-remoteproc@...r.kernel.org, agross@...nel.org,
        bjorn.andersson@...aro.org, lgirdwood@...il.com,
        broonie@...nel.org, quic_plai@...cinc.com, bgoswami@...cinc.com,
        perex@...ex.cz, tiwai@...e.com, srinivas.kandagatla@...aro.org,
        quic_rohkumar@...cinc.com, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, swboyd@...omium.org,
        judyhsiao@...omium.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/8] dt-bindings: remoteproc: qcom: adsp: Add compatible
 name for SC7280

On Wed, Aug 03, 2022 at 07:51:14PM +0530, Srinivasa Rao Mandadapu wrote:
> Add compatible name and update max reg items for SC7280 base platforms.
> 
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
> ---
>  .../devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml          | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml
> index 9f11332..147996f 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml
> @@ -17,11 +17,12 @@ properties:
>    compatible:
>      enum:
>        - qcom,sdm845-adsp-pil
> +      - qcom,sc7280-adsp-pil
>  
>    reg:
> -    maxItems: 1
> +    maxItems: 2

sdm845 has 2 entries too?

>      description:
> -      The base address and size of the qdsp6ss register
> +      The base address and size of the qdsp6ss register and mcc register

Better expressed as:

minItems: 1
items:
  - description: qdsp6ss register
  - description: mcc register

Though the descriptions could expand on what those registers are.

Rob