linux-kernel - Re: [PATCH -next] f2fs: Replace kmalloc() with f2fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YutDc6n08xw0iG+3@google.com>
Date:   Wed, 3 Aug 2022 20:56:35 -0700
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     studentxswpy@....com
Cc:     chao@...nel.org, linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org,
        Hacash Robot <hacashRobot@...tino.com>
Subject: Re: [PATCH -next] f2fs: Replace kmalloc() with f2fs_kmalloc

On 08/01, studentxswpy@....com wrote:
> From: Xie Shaowen <studentxswpy@....com>
> 
> replace kmalloc with f2fs_kmalloc to keep f2fs code consistency.
> 
> Reported-by: Hacash Robot <hacashRobot@...tino.com>
> Signed-off-by: Xie Shaowen <studentxswpy@....com>
> ---
>  fs/f2fs/dir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
> index d5bd7932fb64..712b51f69c04 100644
> --- a/fs/f2fs/dir.c
> +++ b/fs/f2fs/dir.c
> @@ -232,7 +232,7 @@ static int f2fs_match_ci_name(const struct inode *dir, const struct qstr *name,
>  		if (WARN_ON_ONCE(!fscrypt_has_encryption_key(dir)))
>  			return -EINVAL;
>  
> -		decrypted_name.name = kmalloc(de_name_len, GFP_KERNEL);
> +		decrypted_name.name = f2fs_kmalloc(de_name_len, GFP_KERNEL);

Please fix the build breakage.

fyi;

static inline void *f2fs_kmalloc(struct f2fs_sb_info *sbi, size_t size, gfp_t flags)

>  		if (!decrypted_name.name)
>  			return -ENOMEM;
>  		res = fscrypt_fname_disk_to_usr(dir, 0, 0, &encrypted_name,
> -- 
> 2.25.1