| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202208041237.cjPrb4Bv-lkp@intel.com>
Date: Thu, 4 Aug 2022 12:39:20 +0800
From: kernel test robot <lkp@...el.com>
To: Ricardo Ribalda <ribalda@...omium.org>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
Kenny Ho <Kenny.Ho@....com>,
Shuah Khan <skhan@...uxfoundation.org>
Subject: [agd5f:amd-staging-drm-next 986/1023]
drivers/thunderbolt/test.c:799:9: error: implicit declaration of function
'KUNIT_ASSERT_NULL'; did you mean 'KUNIT_ASSERT_LE'?
tree: https://gitlab.freedesktop.org/agd5f/linux.git amd-staging-drm-next
head: 2305916dca043ed69bd464f74a886b0216780aa6
commit: 53069c3922842db6f01ca9008e6a45d0fd3a083e [986/1023] thunderbolt: test: use NULL macros
config: xtensa-randconfig-c032-20220804 (https://download.01.org/0day-ci/archive/20220804/202208041237.cjPrb4Bv-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add agd5f https://gitlab.freedesktop.org/agd5f/linux.git
git fetch --no-tags agd5f amd-staging-drm-next
git checkout 53069c3922842db6f01ca9008e6a45d0fd3a083e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/thunderbolt/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
drivers/thunderbolt/test.c: In function 'tb_test_path_not_connected':
>> drivers/thunderbolt/test.c:799:9: error: implicit declaration of function 'KUNIT_ASSERT_NULL'; did you mean 'KUNIT_ASSERT_LE'? [-Werror=implicit-function-declaration]
799 | KUNIT_ASSERT_NULL(test, path);
| ^~~~~~~~~~~~~~~~~
| KUNIT_ASSERT_LE
drivers/thunderbolt/test.c: In function 'tb_test_path_not_bonded_lane0':
>> drivers/thunderbolt/test.c:850:9: error: implicit declaration of function 'KUNIT_ASSERT_NOT_NULL'; did you mean 'KUNIT_ASSERT_TRUE'? [-Werror=implicit-function-declaration]
850 | KUNIT_ASSERT_NOT_NULL(test, path);
| ^~~~~~~~~~~~~~~~~~~~~
| KUNIT_ASSERT_TRUE
cc1: some warnings being treated as errors
vim +799 drivers/thunderbolt/test.c
783
784 static void tb_test_path_not_connected(struct kunit *test)
785 {
786 struct tb_switch *host, *dev1, *dev2;
787 struct tb_port *down, *up;
788 struct tb_path *path;
789
790 host = alloc_host(test);
791 dev1 = alloc_dev_default(test, host, 0x3, false);
792 /* Not connected to anything */
793 dev2 = alloc_dev_default(test, NULL, 0x303, false);
794
795 down = &dev1->ports[10];
796 up = &dev2->ports[9];
797
798 path = tb_path_alloc(NULL, down, 8, up, 8, 0, "PCIe Down");
> 799 KUNIT_ASSERT_NULL(test, path);
800 path = tb_path_alloc(NULL, down, 8, up, 8, 1, "PCIe Down");
801 KUNIT_ASSERT_NULL(test, path);
802 }
803
804 struct hop_expectation {
805 u64 route;
806 u8 in_port;
807 enum tb_port_type in_type;
808 u8 out_port;
809 enum tb_port_type out_type;
810 };
811
812 static void tb_test_path_not_bonded_lane0(struct kunit *test)
813 {
814 /*
815 * PCIe path from host to device using lane 0.
816 *
817 * [Host]
818 * 3 |: 4
819 * 1 |: 2
820 * [Device]
821 */
822 static const struct hop_expectation test_data[] = {
823 {
824 .route = 0x0,
825 .in_port = 9,
826 .in_type = TB_TYPE_PCIE_DOWN,
827 .out_port = 3,
828 .out_type = TB_TYPE_PORT,
829 },
830 {
831 .route = 0x3,
832 .in_port = 1,
833 .in_type = TB_TYPE_PORT,
834 .out_port = 9,
835 .out_type = TB_TYPE_PCIE_UP,
836 },
837 };
838 struct tb_switch *host, *dev;
839 struct tb_port *down, *up;
840 struct tb_path *path;
841 int i;
842
843 host = alloc_host(test);
844 dev = alloc_dev_default(test, host, 0x3, false);
845
846 down = &host->ports[9];
847 up = &dev->ports[9];
848
849 path = tb_path_alloc(NULL, down, 8, up, 8, 0, "PCIe Down");
> 850 KUNIT_ASSERT_NOT_NULL(test, path);
851 KUNIT_ASSERT_EQ(test, path->path_length, ARRAY_SIZE(test_data));
852 for (i = 0; i < ARRAY_SIZE(test_data); i++) {
853 const struct tb_port *in_port, *out_port;
854
855 in_port = path->hops[i].in_port;
856 out_port = path->hops[i].out_port;
857
858 KUNIT_EXPECT_EQ(test, tb_route(in_port->sw), test_data[i].route);
859 KUNIT_EXPECT_EQ(test, in_port->port, test_data[i].in_port);
860 KUNIT_EXPECT_EQ(test, (enum tb_port_type)in_port->config.type,
861 test_data[i].in_type);
862 KUNIT_EXPECT_EQ(test, tb_route(out_port->sw), test_data[i].route);
863 KUNIT_EXPECT_EQ(test, out_port->port, test_data[i].out_port);
864 KUNIT_EXPECT_EQ(test, (enum tb_port_type)out_port->config.type,
865 test_data[i].out_type);
866 }
867 tb_path_free(path);
868 }
869
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists