[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220804054906epcms2p1f3b7f3dc8be225a96933121e77c6648f@epcms2p1>
Date: Thu, 04 Aug 2022 14:49:06 +0900
From: Jinyoung CHOI <j-young.choi@...sung.com>
To: Bart Van Assche <bvanassche@....org>,
ALIM AKHTAR <alim.akhtar@...sung.com>,
"avri.altman@....com" <avri.altman@....com>,
"jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
"martin.petersen@...cle.com" <martin.petersen@...cle.com>,
"beanhuo@...ron.com" <beanhuo@...ron.com>,
"adrian.hunter@...el.com" <adrian.hunter@...el.com>,
"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"stanley.chu@...iatek.com" <stanley.chu@...iatek.com>
Subject: RE:(2) [PATCH v6 3/6] scsi: ufs: wb: Add explicit flush sysfs
attribute
>On 8/2/22 01:07, Jinyoung CHOI wrote:
>> +What: /sys/bus/platform/drivers/ufshcd/*/wb_buf_flush_en
>> +What: /sys/bus/platform/devices/*.ufs/wb_buf_flush_en
>> +Date: July 2022
>> +Contact: Jinyoung Choi <j-young.choi@...sung.com>
>> +Description: This entry shows the status of WriteBooster buffer flushing
>
>Can we rename this attribute into something that has a word order that
>is grammatically correct, e.g. enable_wb_buf_flush?
>
OK, I will replace it.
Instead, When the list is printed through "ls",
it may be difficult to check because the prefix is different.
>> + and it can be used to allow or disallow the flushing.
>> + If the flushing is allowed, the device executes the flush
>> + operation when the command queue is empty.
>
>The attribute has "enabled" in its name while the above text uses the
>verb "allowed". Consider changing "allowed" into "enabled". Please also
>change "If the flushing" into "If flushing".
>
>Thanks,
>
>Bart
OK, I will apply next patch.
Warm Regards,
Jinyoung.
Powered by blists - more mailing lists