[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f1e00958-d889-d6d0-db41-fb79cb614a7a@kernel.org>
Date: Thu, 4 Aug 2022 08:47:57 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Nick Desaulniers <ndesaulniers@...gle.com>,
Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org,
Michal Marek <michal.lkml@...kovi.net>,
linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
"H. Peter Anvin" <hpa@...ux.intel.com>
Subject: Re: [PATCH 3/3] Revert "Kbuild, lto, workaround: Don't warn for
initcall_reference in modpost"
On 02. 08. 22, 20:04, Nick Desaulniers wrote:
> On Sat, Jul 30, 2022 at 10:37 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>>
>> This reverts commit 77ab21adae509c5540956729e2d03bc1a59bc82a.
>>
>> That commit was 8 years old, and it said "This is a workaround".
>> If this is needed for GCC LTO, it should be added in a proper way.
>>
>> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
>
> Please don't forget to cc the author & reviewers for a patch when
> submitting a revert.
>
> + Jiri in case a patch needs to be carried in any downstream trees for
> re-application.
IMO we already got rid of -fno-toplevel-reorder (we have noreorder
attribute now), so:
Acked-by: Jiri Slaby <jirislaby@...nel.org>
> Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>
Thanks for letting me know.
>> scripts/mod/modpost.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
>> index c6a055c0291e..a8ee27496da7 100644
>> --- a/scripts/mod/modpost.c
>> +++ b/scripts/mod/modpost.c
>> @@ -1462,9 +1462,6 @@ static void default_mismatch_handler(const char *modname, struct elf_info *elf,
>> from = find_elf_symbol2(elf, r->r_offset, fromsec);
>> fromsym = sym_name(elf, from);
>>
>> - if (strstarts(fromsym, "reference___initcall"))
>> - return;
>> -
>> tosec = sec_name(elf, get_secindex(elf, sym));
>> to = find_elf_symbol(elf, r->r_addend, sym);
>> tosym = sym_name(elf, to);
>> --
>> 2.34.1
>>
>
>
--
js
suse labs
Powered by blists - more mailing lists