linux-kernel - Re: [dm-devel] [PATCH v9 05/13] nvme: zns: Allow ZNS drives that have non-power_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73f35f39-9637-056e-91b9-ee6b2c104977@samsung.com>
Date:   Thu, 4 Aug 2022 09:29:44 +0200
From:   Pankaj Raghav <p.raghav@...sung.com>
To:     Bart Van Assche <bvanassche@....org>, <Johannes.Thumshirn@....com>,
        <snitzer@...nel.org>, <axboe@...nel.dk>,
        <damien.lemoal@...nsource.wdc.com>, <agk@...hat.com>, <hch@....de>
CC:     <pankydev8@...il.com>, <gost.dev@...sung.com>,
        <linux-kernel@...r.kernel.org>, <linux-nvme@...ts.infradead.org>,
        <linux-block@...r.kernel.org>, <dm-devel@...hat.com>,
        <jaegeuk@...nel.org>, <matias.bjorling@....com>,
        Luis Chamberlain <mcgrof@...nel.org>
Subject: Re: [dm-devel] [PATCH v9 05/13] nvme: zns: Allow ZNS drives that
 have non-power_of_2 zone size

Hi Bart,

On 2022-08-03 19:22, Bart Van Assche wrote:
> On 8/3/22 02:47, Pankaj Raghav wrote:
>> -    sector &= ~(ns->zsze - 1);
>> +    /*
>> +     * Round down the sector value to the nearest zone start
>> +     */
>> +    div64_u64_rem(sector, ns->zsze, &remainder);
>> +    sector -= remainder;
> 
> Could bdev_offset_from_zone_start() be used here?
> 
We call this function during blk_revalidate_disk_zones() to evaluate the
chunk sectors. So we can't call bdev_offset_from_zone_start() from here
as the chunk_sectors will not be initialized yet :)