linux-kernel - Re: [PATCH v1] platform/chrome: cros_ec_proto: Update version on GET_NEXT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YuuKu4b02siXj/TS@google.com>
Date:   Thu, 4 Aug 2022 09:00:43 +0000
From:   Tzung-Bi Shih <tzungbi@...nel.org>
To:     Patryk Duda <pdk@...ihalf.com>
Cc:     Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Gwendal Grignou <gwendal@...gle.com>,
        chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org,
        upstream@...ihalf.com
Subject: Re: [PATCH v1] platform/chrome: cros_ec_proto: Update version on
 GET_NEXT_EVENT failure

On Tue, Aug 02, 2022 at 05:41:28PM +0200, Patryk Duda wrote:
> Fixes: 3300fdd630d4 ("platform/chrome: cros_ec: handle MKBP more events flag")
> Cc: <stable@...r.kernel.org> # 5.10+

Any concerns if removing the Cc tag?  As I think a Fixes tag should be
sufficient.  On a related note, why did you specify for only 5.10+?

> Signed-off-by: Patryk Duda <pdk@...ihalf.com>

You should collect the Reviewed-by tags the patch already got as dropping
`ver_mask` initialization isn't a big change.  I could do that for the patch
this time.

[...]
> v0 -> v1
> - Dropped `ver_mask` initialization.

Please start versioning from v1 next time.