linux-kernel - Re: [PATCH 1/3] cxl/regions: add padding for cxl_rr_ep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220804101503.000039ff@huawei.com>
Date:   Thu, 4 Aug 2022 10:15:03 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Bagas Sanjaya <bagasdotme@...il.com>
CC:     <linux-doc@...r.kernel.org>, <linux-cxl@...r.kernel.org>,
        <linux-next@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>,
        Alison Schofield <alison.schofield@...el.com>,
        "Vishal Verma" <vishal.l.verma@...el.com>,
        Ira Weiny <ira.weiny@...el.com>,
        "Ben Widawsky" <bwidawsk@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH 1/3] cxl/regions: add padding for cxl_rr_ep_add nested
 lists

On Thu,  4 Aug 2022 14:54:46 +0700
Bagas Sanjaya <bagasdotme@...il.com> wrote:

> Sphinx reported indentation warnings:
> 
> Documentation/driver-api/cxl/memory-devices:457: ./drivers/cxl/core/region.c:732: WARNING: Unexpected indentation.
> Documentation/driver-api/cxl/memory-devices:457: ./drivers/cxl/core/region.c:733: WARNING: Block quote ends without a blank line; unexpected unindent.
> Documentation/driver-api/cxl/memory-devices:457: ./drivers/cxl/core/region.c:735: WARNING: Unexpected indentation.
> 
> These warnings above are due to missing blank line padding in the nested list
> in kernel-doc comment for cxl_rr_ep_add().
> 
> Add the paddings to fix the warnings.
> 
> Fixes: 384e624bb211b4 ("cxl/region: Attach endpoint decoders")
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>
Looks right to me.  Sphinx white space around lists is annoyingly fiddly but
such is life.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  drivers/cxl/core/region.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index dc71ec457608d2..616db51c4e78cf 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -728,11 +728,14 @@ static int cxl_rr_ep_add(struct cxl_region_ref *cxl_rr,
>   * in particular decoder target lists.
>   *
>   * The steps are:
> + *
>   * - validate that there are no other regions with a higher HPA already
>   *   associated with @port
>   * - establish a region reference if one is not already present
> + *
>   *   - additionally allocate a decoder instance that will host @cxlr on
>   *     @port
> + *
>   * - pin the region reference by the endpoint
>   * - account for how many entries in @port's target list are needed to
>   *   cover all of the added endpoints.