linux-kernel - Re: [PATCH resend] ASoC: SOF: ipc3-topology: Fix clang -Wformat warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43ada0d7-f094-7f63-3717-30c64834edd6@linux.intel.com>
Date:   Thu, 4 Aug 2022 11:47:46 +0200
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Nathan Chancellor <nathan@...nel.org>,
        Justin Stitt <justinstitt@...gle.com>
Cc:     Daniel Baluta <daniel.baluta@....com>, alsa-devel@...a-project.org,
        llvm@...ts.linux.dev, Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Takashi Iwai <tiwai@...e.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Tom Rix <trix@...hat.com>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        linux-kernel@...r.kernel.org, sound-open-firmware@...a-project.org
Subject: Re: [PATCH resend] ASoC: SOF: ipc3-topology: Fix clang -Wformat
 warning



On 8/3/22 15:47, Nathan Chancellor wrote:
> On Wed, Aug 03, 2022 at 01:44:42PM -0700, Justin Stitt wrote:
>> When building with Clang we encounter these warnings:
>> | sound/soc/sof/ipc3-topology.c:2343:4: error: format specifies type
>> | 'unsigned char' but the argument has type 'int' [-Werror,-Wformat]
>> |                  SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH);
>> |                  ^~~~~~~~~~~~~~~^~~~~~~~~~~~~~~^~~~~~~~~~~~~
>>
>> Use correct format specifier `%d` since args are of type int.
>>
>> Link: https://github.com/ClangBuiltLinux/linux/issues/378
>> Reported-by: Nathan Chancellor <nathan@...nel.org>
>> Suggested-by: Nathan Chancellor <nathan@...nel.org>
>> Signed-off-by: Justin Stitt <justinstitt@...gle.com>
> 
> Thanks for resending!
> 
> Reviewed-by: Nathan Chancellor <nathan@...nel.org>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>

> 
>> ---
>> Note: resending with the subject corrected, this patch fixes a build
>> warning that will break the Clang build when CONFIG_WERROR=y.
>>
>> Original patch: https://lore.kernel.org/all/20220721211218.4039288-1-justinstitt@google.com/
>> Reported by Nathan here: https://lore.kernel.org/all/YtmrCJjQrSbv8Aj1@dev-arch.thelio-3990X/
>>
>>  sound/soc/sof/ipc3-topology.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/sof/ipc3-topology.c b/sound/soc/sof/ipc3-topology.c
>> index b2cc046b9f60..65923e7a5976 100644
>> --- a/sound/soc/sof/ipc3-topology.c
>> +++ b/sound/soc/sof/ipc3-topology.c
>> @@ -2338,7 +2338,7 @@ static int sof_ipc3_parse_manifest(struct snd_soc_component *scomp, int index,
>>  	}
>>  
>>  	dev_info(scomp->dev,
>> -		 "Topology: ABI %d:%d:%d Kernel ABI %hhu:%hhu:%hhu\n",
>> +		 "Topology: ABI %d:%d:%d Kernel ABI %d:%d:%d\n",
>>  		 man->priv.data[0], man->priv.data[1], man->priv.data[2],
>>  		 SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH);
>>  
>> -- 
>> 2.37.1.359.gd136c6c3e2-goog
>>