linux-kernel - Re: [PATCH] clk: qcom: gcc-sdm660: Use floor ops for SDCC1 clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f66c2053-74bd-04fb-13e4-8eeb7f426608@postmarketos.org>
Date:   Thu, 4 Aug 2022 04:29:17 +0300
From:   Alexey Minnekhanov <alexeymin@...tmarketos.org>
To:     Marijn Suijten <marijn.suijten@...ainline.org>,
        phone-devel@...r.kernel.org
Cc:     ~postmarketos/upstreaming@...ts.sr.ht,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Martin Botka <martin.botka@...ainline.org>,
        Jami Kettunen <jami.kettunen@...ainline.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Taniya Das <tdas@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: qcom: gcc-sdm660: Use floor ops for SDCC1 clock

On 7/14/22 23:38, Marijn Suijten wrote:
> In commit 3f905469c8ce ("clk: qcom: gcc: Use floor ops for SDCC clocks")
> floor ops were applied to SDCC2 only, but flooring is also required on
> the SDCC1 apps clock which is used by the eMMC card on Sony's Nile
> platform, and otherwise result in the typicial "Card appears
> overclocked" warnings observed on many other platforms before:
> 
>      mmc0: Card appears overclocked; req 52000000 Hz, actual 100000000 Hz
>      mmc0: Card appears overclocked; req 52000000 Hz, actual 100000000 Hz
>      mmc0: Card appears overclocked; req 104000000 Hz, actual 192000000 Hz
> 
> Fixes: f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver for SDM660")
> Signed-off-by: Marijn Suijten <marijn.suijten@...ainline.org>
>

Tried this on my SDM660 xiaomi-lavender, warnings are gone, thanks!

Tested-by: Alexey Minnekhanov <alexeymin@...tmarketos.org>