linux-kernel - Re: [PATCH 2/2] ASoC: SOF: mediatek: Add .of_machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YuvKjn3cW5im2Yw9@sirena.org.uk>
Date:   Thu, 4 Aug 2022 14:33:02 +0100
From:   Mark Brown <broonie@...nel.org>
To:     "chunxu.li" <chunxu.li@...iatek.com>
Cc:     pierre-louis.bossart@...ux.intel.com,
        peter.ujfalusi@...ux.intel.com, lgirdwood@...il.com,
        angelogioacchino.delregno@...labora.com, daniel.baluta@....com,
        matthias.bgg@...il.com, yc.hung@...iatek.com,
        tinghan.shen@...iatek.com, linux-kernel@...r.kernel.org,
        alsa-devel@...a-project.org, sound-open-firmware@...a-project.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        project_global_chrome_upstream_group@...iatek.com
Subject: Re: [PATCH 2/2] ASoC: SOF: mediatek: Add .of_machine_select field
 for mt8186

On Thu, Aug 04, 2022 at 09:21:37PM +0800, chunxu.li wrote:
> On Thu, 2022-08-04 at 13:41 +0100, Mark Brown wrote:
> > On Thu, Aug 04, 2022 at 05:13:59PM +0800, Chunxu Li wrote:

> > > +		.board = "mediatek,mt8186",
> > > +		.sof_tplg_filename = "sof-mt8186.tplg",

> > The mediatek,mt8186 compatible looks like a SoC compatible not a
> > board
> > compatible...

> Our dts config as below:
> kingler board:
> compatible = "google,corsola", "google,kingler", "mediatek,mt8186";
> krabby board:
> compatible = "google,corsola", "google,krabby", "mediatek,mt8186";

So the SoC is listed as a fallback for the board and things work out
fine.

> Which of the two approaches do you prefer?

I think it would be clearer to keep what's being matched the same but
rename the .board field to be .compatible, or possibly .system_compatible
or something if it's unclear what's being matched.  That'd be more
normal for specifying a compatible string anyway.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)