linux-kernel - Re: [PATCH 2/3] cxl/region: describe targets and nr_targets members of cxl_region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220804143540.000041c2@huawei.com>
Date:   Thu, 4 Aug 2022 14:35:40 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Bagas Sanjaya <bagasdotme@...il.com>
CC:     <linux-doc@...r.kernel.org>, <linux-cxl@...r.kernel.org>,
        <linux-next@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>,
        Alison Schofield <alison.schofield@...el.com>,
        "Vishal Verma" <vishal.l.verma@...el.com>,
        Ira Weiny <ira.weiny@...el.com>,
        "Ben Widawsky" <bwidawsk@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH 2/3] cxl/region: describe targets and nr_targets members
 of cxl_region_params

On Thu,  4 Aug 2022 14:54:47 +0700
Bagas Sanjaya <bagasdotme@...il.com> wrote:

> Sphinx reported undescribed parameters in cxl_region_params struct:
> 
> ./drivers/cxl/cxl.h:376: warning: Function parameter or member 'targets' not described in 'cxl_region_params'
> ./drivers/cxl/cxl.h:376: warning: Function parameter or member 'nr_targets' not described in 'cxl_region_params'
> 
> Describe these members.
> 
> Fixes: dd5ba0ebbdc414 ("cxl/region: Add a 'uuid' attribute")
That seems unlikely to be right tag. Probably b9686e8c8e39

With that tidied up.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>
> ---
>  drivers/cxl/cxl.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
> index 75674400cc8d41..65aaf15aa17e29 100644
> --- a/drivers/cxl/cxl.h
> +++ b/drivers/cxl/cxl.h
> @@ -362,6 +362,8 @@ enum cxl_config_state {
>   * @interleave_ways: number of endpoints in the region
>   * @interleave_granularity: capacity each endpoint contributes to a stripe
>   * @res: allocated iomem capacity for this region
> + * @targets: active ordered targets in current decoder configuration
> + * @nr_targets: number of targets
>   *
>   * State transitions are protected by the cxl_region_rwsem
>   */