linux-kernel - RE: [EXT] Re: [PATCH 1/1] serial: fsl_lpuart: RS485 RTS polariy is inverse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Aug 2022 14:35:26 +0000
From:   Shenwei Wang <shenwei.wang@....com>
To:     Jiri Slaby <jirislaby@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        Nicolas Diaz <nicolas.diaz@....com>
Subject: RE: [EXT] Re: [PATCH 1/1] serial: fsl_lpuart: RS485 RTS polariy is
 inverse



> -----Original Message-----
> From: Jiri Slaby <jirislaby@...nel.org>
> Sent: Thursday, August 4, 2022 1:51 AM
> To: Shenwei Wang <shenwei.wang@....com>; gregkh@...uxfoundation.org
> Cc: linux-serial@...r.kernel.org; linux-kernel@...r.kernel.org; dl-linux-imx
> <linux-imx@....com>; Nicolas Diaz <nicolas.diaz@....com>
> Subject: [EXT] Re: [PATCH 1/1] serial: fsl_lpuart: RS485 RTS polariy is inverse
> 
> Caution: EXT Email
> 
> On 02. 08. 22, 18:38, Shenwei Wang wrote:
> > The setting of RS485 RTS polarity is inverse in the current driver.
> >
> > When the property of 'rs485-rts-active-low' is enabled in the dts
> > node, the RTS signal should be LOW during sending. Otherwise, if there
> > is no such a property, the RTS should be HIGH during sending.
> 
> What commit this fixes? I.e. I am missing a Fixes tag below.

It is a fix for the following commit:
Fixes: 03895cf41d18 ("tty: serial: fsl_lpuart: Add support for RS-485")

Should I send out a new version to update it?

Thanks,
Shenwei

> 
> > Signed-off-by: Nicolas Diaz <nicolas.diaz@....com>
> > Signed-off-by: Shenwei Wang <shenwei.wang@....com>
> > ---
> >   drivers/tty/serial/fsl_lpuart.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/tty/serial/fsl_lpuart.c
> > b/drivers/tty/serial/fsl_lpuart.c index afa0f941c862f..abc3a3674bc39
> > 100644
> > --- a/drivers/tty/serial/fsl_lpuart.c
> > +++ b/drivers/tty/serial/fsl_lpuart.c
> > @@ -1394,9 +1394,9 @@ static int lpuart_config_rs485(struct uart_port *port,
> struct ktermios *termios,
> >                * Note: UART is assumed to be active high.
> >                */
> >               if (rs485->flags & SER_RS485_RTS_ON_SEND)
> > -                     modem &= ~UARTMODEM_TXRTSPOL;
> > -             else if (rs485->flags & SER_RS485_RTS_AFTER_SEND)
> >                       modem |= UARTMODEM_TXRTSPOL;
> > +             else if (rs485->flags & SER_RS485_RTS_AFTER_SEND)
> > +                     modem &= ~UARTMODEM_TXRTSPOL;
> >       }
> >
> >       writeb(modem, sport->port.membase + UARTMODEM);
> 
> thanks,
> --
> js
> suse labs