linux-kernel - Re: [PATCH 1/2] ASoC: SOF: Introduce optional callback of_machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 4 Aug 2022 15:59:26 +0100
From:   Mark Brown <broonie@...nel.org>
To:     "chunxu.li" <chunxu.li@...iatek.com>
Cc:     pierre-louis.bossart@...ux.intel.com,
        peter.ujfalusi@...ux.intel.com, lgirdwood@...il.com,
        angelogioacchino.delregno@...labora.com, daniel.baluta@....com,
        matthias.bgg@...il.com, yc.hung@...iatek.com,
        tinghan.shen@...iatek.com, linux-kernel@...r.kernel.org,
        alsa-devel@...a-project.org, sound-open-firmware@...a-project.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        project_global_chrome_upstream_group@...iatek.com
Subject: Re: [PATCH 1/2] ASoC: SOF: Introduce optional callback
 of_machine_select

On Thu, Aug 04, 2022 at 10:36:07PM +0800, chunxu.li wrote:

> Thanks for you advice, I'll remove the callback function, and directly
> call sof_of_machine_select() in sof_machine_check() as following.
> 
> int sof_machine_check(struct snd_sof_dev *sdev)
> {
> 	}
> 
> 	
> +	of_mach = sof_of_machine_select(sdev);
> +	if (of_mach) {
> +		sof_pdata->of_machine = of_mach;
> +		return 0;
> +	}

Looks good.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)