[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6fef92f3-6932-5c20-57fe-9eb40d676013@molgen.mpg.de>
Date: Thu, 4 Aug 2022 17:01:08 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Tomer Maimon <tmaimon77@...il.com>
Cc: avifishman70@...il.com, tali.perry1@...il.com, joel@....id.au,
venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com,
jic23@...nel.org, minyard@....org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, devicetree@...r.kernel.org,
openbmc@...ts.ozlabs.org, openipmi-developer@...ts.sourceforge.net,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible
Dear Tomer,
Am 04.08.22 um 16:55 schrieb Tomer Maimon:
> Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible
> string.
>
> Signed-off-by: Tomer Maimon <tmaimon77@...il.com>
> ---
> Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> index cbc10a68ddef..4fda76e63396 100644
> --- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> +++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> @@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host.
> Required properties:
> - compatible : should be one of
> "nuvoton,npcm750-kcs-bmc"
> - "nuvoton,npcm845-kcs-bmc"
> + "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc"
Isn’t the added string exactly the same as the one below the compatible
line?
> - interrupts : interrupt generated by the controller
> - kcs_chan : The KCS channel number in the controller
Kind regards,
Paul
Powered by blists - more mailing lists