linux-kernel - Re: [PATCH] docs/kselftest: Fix build commands in guidelines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 Aug 2022 20:18:34 +0500
From:   Muhammad Usama Anjum <usama.anjum@...labora.com>
To:     Jonathan Corbet <corbet@....net>
Cc:     usama.anjum@...labora.com, kernel@...labora.com,
        linux-kselftest@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] docs/kselftest: Fix build commands in guidelines

On 7/26/22 9:59 AM, Muhammad Usama Anjum wrote:
> On 7/8/22 9:51 PM, Shuah Khan wrote:
>> On 7/4/22 2:34 AM, Muhammad Usama Anjum wrote:
>>> Build commands start with "make". It is missing. Add "make" to the start
>>> of the build command.
>>>
>>> Fixes: 820636106342 ("docs/kselftest: add more guidelines for adding
>>> new tests")
>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
>>> ---
>>>   Documentation/dev-tools/kselftest.rst | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Documentation/dev-tools/kselftest.rst
>>> b/Documentation/dev-tools/kselftest.rst
>>> index ee6467ca8293..9dd94c334f05 100644
>>> --- a/Documentation/dev-tools/kselftest.rst
>>> +++ b/Documentation/dev-tools/kselftest.rst
>>> @@ -255,9 +255,9 @@ Contributing new tests (details)
>>>      * All changes should pass::
>>>   -    kselftest-{all,install,clean,gen_tar}
>>> -    kselftest-{all,install,clean,gen_tar} O=abo_path
>>> -    kselftest-{all,install,clean,gen_tar} O=rel_path
>>> +    make kselftest-{all,install,clean,gen_tar}
>>> +    make kselftest-{all,install,clean,gen_tar} O=abs_path
>>> +    make kselftest-{all,install,clean,gen_tar} O=rel_path
>>>       make -C tools/testing/selftests {all,install,clean,gen_tar}
>>>       make -C tools/testing/selftests {all,install,clean,gen_tar}
>>> O=abs_path
>>>       make -C tools/testing/selftests {all,install,clean,gen_tar}
>>> O=rel_path
>>>
>>
>> Looks like it depends on a patch already in doc tree?
> Yes, the dependent patch is in doc tree. Corbet should pick up this patch.
Reminder!

>> Acked-by: Shuah Khan <skhan@...uxfoundation.org>
>>
>> thanks,
>> -- Shuah
> 

-- 
Muhammad Usama Anjum