lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YuvxlOlGmPTbblaP@pendragon.ideasonboard.com>
Date:   Thu, 4 Aug 2022 19:19:32 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Jason Wang <wangborong@...rlc.com>
Cc:     mchehab@...nel.org, hverkuil-cisco@...all.nl,
        ezequiel@...guardiasur.com.ar, sakari.ailus@...ux.intel.com,
        ribalda@...omium.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: v4l2: Fix comment typo

Hi Jason,

On Thu, Aug 04, 2022 at 08:05:04PM +0800, Jason Wang wrote:
> The double `the' is duplicated in the comment, remove one.
> 
> Signed-off-by: Jason Wang <wangborong@...rlc.com>
> ---
>  drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> index e6fd355a2e92..af75edee898c 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -1045,7 +1045,7 @@ static void v4l_sanitize_format(struct v4l2_format *fmt)
>  	/*
>  	 * The v4l2_pix_format structure has been extended with fields that were
>  	 * not previously required to be set to zero by applications. The priv
> -	 * field, when set to a magic value, indicates the the extended fields
> +	 * field, when set to a magic value, indicates the extended fields

I wonder if the original intent was to write "indicates that the
extended fields ...".

>  	 * are valid. Otherwise they will contain undefined values. To simplify
>  	 * the API towards drivers zero the extended fields and set the priv
>  	 * field to the magic value when the extended pixel format structure

-- 
Regards,

Laurent Pinchart

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ