linux-kernel - Re: [PATCH 2/2] mm: Remember young bit for page migrations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <40FDA6B1-EB53-484D-91A0-323606199C4E@gmail.com>
Date:   Thu, 4 Aug 2022 10:16:50 -0700
From:   Nadav Amit <nadav.amit@...il.com>
To:     Peter Xu <peterx@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, Linux MM <linux-mm@...ck.org>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Andi Kleen <andi.kleen@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Hugh Dickins <hughd@...gle.com>,
        Huang Ying <ying.huang@...el.com>,
        "Kirill A . Shutemov" <kirill@...temov.name>,
        Vlastimil Babka <vbabka@...e.cz>,
        David Hildenbrand <david@...hat.com>,
        Minchan Kim <minchan@...nel.org>
Subject: Re: [PATCH 2/2] mm: Remember young bit for page migrations

On Aug 4, 2022, at 10:07 AM, Peter Xu <peterx@...hat.com> wrote:

> On Wed, Aug 03, 2022 at 11:42:39PM -0700, Nadav Amit wrote:
>> On Aug 3, 2022, at 9:45 AM, Peter Xu <peterx@...hat.com> wrote:
> 
> For this series, I can think more of dropping the young bit for migration
> entry during these madvises (which should be relatively safe with the
> pgtable held, since I don't need to touch the page but just modify the swap
> entry within), but probably that's not really the major problem here, so
> not sure whether that matters a huge lot (e.g., for FREE we should really
> drop the whole entry?).

Sounds good to me. I just had a look whether the swap entry should be
checked and hit these additional cases, so I thought they are worthy of
consideration. But as they are already not handling some cases, which is
valid for madvise's hints, leaving it to later sounds fine.

Handling migration entries anyhow might not be worthy of the risk of
breaking something.