| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 4 Aug 2022 10:54:36 -0700
From: Doug Anderson <dianders@...omium.org>
To: Robert Foss <robert.foss@...aro.org>
Cc: Vinod Polimera <quic_vpolimer@...cinc.com>,
dri-devel <dri-devel@...ts.freedesktop.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
freedreno <freedreno@...ts.freedesktop.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
Rob Clark <robdclark@...il.com>,
Stephen Boyd <swboyd@...omium.org>,
quic_kalyant <quic_kalyant@...cinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
"Kuogee Hsieh (QUIC)" <quic_khsieh@...cinc.com>,
quic_vproddut <quic_vproddut@...cinc.com>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
"Aravind Venkateswaran (QUIC)" <quic_aravindh@...cinc.com>,
"Abhinav Kumar (QUIC)" <quic_abhinavk@...cinc.com>,
Sankeerth Billakanti <quic_sbillaka@...cinc.com>
Subject: Re: [PATCH v6 00/10] Add PSR support for eDP
Hi,
On Thu, Aug 4, 2022 at 9:21 AM Robert Foss <robert.foss@...aro.org> wrote:
>
> On Fri, 29 Jul 2022 at 02:22, Doug Anderson <dianders@...omium.org> wrote:
> >
> > Hi,
> >
> > On Mon, Jul 11, 2022 at 5:57 AM Vinod Polimera
> > <quic_vpolimer@...cinc.com> wrote:
> > >
> > > Changes in v2:
> > > - Use dp bridge to set psr entry/exit instead of dpu_enocder.
> > > - Don't modify whitespaces.
> > > - Set self refresh aware from atomic_check.
> > > - Set self refresh aware only if psr is supported.
> > > - Provide a stub for msm_dp_display_set_psr.
> > > - Move dp functions to bridge code.
> > >
> > > Changes in v3:
> > > - Change callback names to reflect atomic interfaces.
> > > - Move bridge callback change to separate patch as suggested by Dmitry.
> > > - Remove psr function declaration from msm_drv.h.
> > > - Set self_refresh_aware flag only if psr is supported.
> > > - Modify the variable names to simpler form.
> > > - Define bit fields for PSR settings.
> > > - Add comments explaining the steps to enter/exit psr.
> > > - Change DRM_INFO to drm_dbg_db.
> > >
> > > Changes in v4:
> > > - Move the get crtc functions to drm_atomic.
> > > - Add atomic functions for DP bridge too.
> > > - Add ternary operator to choose eDP or DP ops.
> > > - Return true/false instead of 1/0.
> > > - mode_valid missing in the eDP bridge ops.
> > > - Move the functions to get crtc into drm_atomic.c.
> > > - Fix compilation issues.
> > > - Remove dpu_assign_crtc and get crtc from drm_enc instead of dpu_enc.
> > > - Check for crtc state enable while reserving resources.
> > >
> > > Changes in v5:
> > > - Move the mode_valid changes into a different patch.
> > > - Complete psr_op_comp only when isr is set.
> > > - Move the DP atomic callback changes to a different patch.
> > > - Get crtc from drm connector state crtc.
> > > - Move to separate patch for check for crtc state enable while
> > > reserving resources.
> > >
> > > Changes in v6:
> > > - Remove crtc from dpu_encoder_virt struct.
> > > - fix crtc check during vblank toggle crtc.
> > > - Misc changes.
> > >
> > > Signed-off-by: Sankeerth Billakanti <quic_sbillaka@...cinc.com>
> > > Signed-off-by: Kalyan Thota <quic_kalyant@...cinc.com>
> > > Signed-off-by: Vinod Polimera <quic_vpolimer@...cinc.com>
> > >
> > > Vinod Polimera (10):
> > > drm/msm/disp/dpu: clear dpu_assign_crtc and get crtc from connector
> > > state instead of dpu_enc
> > > drm: add helper functions to retrieve old and new crtc
> > > drm/msm/dp: use atomic callbacks for DP bridge ops
> > > drm/msm/dp: Add basic PSR support for eDP
> > > drm/msm/dp: use the eDP bridge ops to validate eDP modes
> > > drm/bridge: use atomic enable/disable callbacks for panel bridge
> > > drm/bridge: add psr support for panel bridge callbacks
> > > drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder
> > > functions
> > > drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver
> > > drm/msm/disp/dpu: check for crtc enable rather than crtc active to
> > > release shared resources
> > >
> > > drivers/gpu/drm/bridge/panel.c | 68 ++++++++--
> > > drivers/gpu/drm/drm_atomic.c | 60 +++++++++
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 17 ++-
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 56 +++++----
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 8 --
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +-
> > > drivers/gpu/drm/msm/dp/dp_catalog.c | 81 ++++++++++++
> > > drivers/gpu/drm/msm/dp/dp_catalog.h | 4 +
> > > drivers/gpu/drm/msm/dp/dp_ctrl.c | 73 +++++++++++
> > > drivers/gpu/drm/msm/dp/dp_ctrl.h | 3 +
> > > drivers/gpu/drm/msm/dp/dp_display.c | 31 +++--
> > > drivers/gpu/drm/msm/dp/dp_display.h | 2 +
> > > drivers/gpu/drm/msm/dp/dp_drm.c | 184 ++++++++++++++++++++++++++--
> > > drivers/gpu/drm/msm/dp/dp_drm.h | 9 +-
> > > drivers/gpu/drm/msm/dp/dp_link.c | 36 ++++++
> > > drivers/gpu/drm/msm/dp/dp_panel.c | 22 ++++
> > > drivers/gpu/drm/msm/dp/dp_panel.h | 6 +
> > > drivers/gpu/drm/msm/dp/dp_reg.h | 27 ++++
> > > include/drm/drm_atomic.h | 7 ++
> > > 19 files changed, 631 insertions(+), 65 deletions(-)
> >
>
> Which tree does this series apply to?
It ought to apply to msm-next, but as I mentioned in my reply to patch
#1 it doesn't apply to the top of msm-next. I think I also had to
manually apply a few of the later patches with "patch -p1".
-Doug
Powered by blists - more mailing lists