linux-kernel - Re: [PATCH v2] mm/gup.c: Simplify and fix check_and_migrate_movable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87czdg7tlt.fsf@nvdebian.thelocal>
Date:   Thu, 04 Aug 2022 10:12:59 +1000
From:   Alistair Popple <apopple@...dia.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-mm@...ck.org, jgg@...dia.com, minchan@...nel.org,
        linux-kernel@...r.kernel.org, jhubbard@...dia.com,
        pasha.tatashin@...een.com, david@...hat.com
Subject: Re: [PATCH v2] mm/gup.c: Simplify and fix
 check_and_migrate_movable_pages() return codes


Andrew Morton <akpm@...ux-foundation.org> writes:

> On Tue,  2 Aug 2022 10:30:12 +1000 Alistair Popple <apopple@...dia.com> wrote:
>
>> When pinning pages with FOLL_LONGTERM check_and_migrate_movable_pages()
>> is called to migrate pages out of zones which should not contain any
>> longterm pinned pages.
>>
>> When migration succeeds all pages will have been unpinned so pinning
>> needs to be retried. This is indicated by returning zero. When all pages
>> are in the correct zone the number of pinned pages is returned.
>>
>> However migration can also fail, in which case pages are unpinned and
>> -ENOMEM is returned. However if the failure was due to not being unable
>> to isolate a page zero is returned. This leads to indefinite looping in
>> __gup_longterm_locked().
>>
>> Fix this by simplifying the return codes such that zero indicates all
>> pages were successfully pinned in the correct zone while errors indicate
>> either pages were migrated and pinning should be retried or that
>> migration has failed and therefore the pinning operation should fail.
>>
>> This fixes the indefinite looping on page isolation failure by failing
>> the pin operation instead of retrying indefinitely.
>>
>
> Are we able to identify a Fixes: for this?  Presumably something in the
> series "Add MEMORY_DEVICE_COHERENT for coherent device memory mapping"?

It seems the infinite loop was desired behaviour so I will re-spin this
as a pure clean-up.