linux-kernel - Re: [PATCH v2 1/1] asus-wmi: Add support for TUF laptop keyboard states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ybhjXWmB07-FDJ_Shcl8d3jd7Y6SJdoQ1XPQrxe1q6MVogS6BaYdjkf-g9DAdXWvfmmemMVGWk9t34LDhiJTFidhVXkkfOwXHMNx-f1Vgq0=@protonmail.com>
Date:   Thu, 04 Aug 2022 21:53:39 +0000
From:   Barnabás Pőcze <pobrn@...tonmail.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     "Luke D. Jones" <luke@...nes.dev>, markgross@...nel.org,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] asus-wmi: Add support for TUF laptop keyboard states

Hi Hans


2022. augusztus 4., csütörtök 15:22 keltezéssel, Hans de Goede <hdegoede@...hat.com> írta:

> [...]
> Please make this an extra attribute for the led_class_device,
> you can do this by adding this attribute to a separate
> attribute_group, lets say e.g. "tuf_rgb_attributes" and then
> in the "[PATCH] asus-wmi: Add support for TUF laptop keyboard RGB"
> code add:
>
> 	mc_cdev->led_cdev.groups = tuf_rgb_attributes;
>
> and then the "tuf_krgb_state" file should show up as:
> /sys/class/leds/asus::multicolour/tuf_krgb_state

I am not sure this will work because `led_classdev_multicolor_register_ext()`
overrides the embedded LED device's `led_classdev::groups` with
`led_multicolor_groups` to provide the multi-color functionality
before calling `led_classdev_register_ext()`.


> [...]


Regards,
Barnabás Pőcze