[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YuxKFpcdqW7Sq1c/@equinox>
Date: Thu, 4 Aug 2022 23:37:10 +0100
From: Phillip Potter <phil@...lpotter.co.uk>
To: Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc: gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
paskripkin@...il.com, straube.linux@...il.com, martin@...ser.cx,
abdun.nihaal@...il.com, linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: convert rtw_p2p_enable to correct
error code semantics
On Thu, Aug 04, 2022 at 10:26:39PM +0200, Philipp Hortmann wrote:
> On 8/3/22 01:44, Phillip Potter wrote:
> > Convert the rtw_p2p_enable function to use correct error code semantics
> > rather than _SUCCESS/_FAIL, and also make sure we allow these to be
> > passed through properly in the one caller where we actually check the
> > code, rtw_wext_p2p_enable.
> >
> > This change moves these functions to a clearer 'return 0;' style at the
> > end of the function, and in the case of errors now returns ret instead
> > of jumping to the end of the function, so that these can still be passed
> > through but without using a goto to jump to a single return statement at
> > the end which is less clear.
> >
> > This change moves the driver slowly closer to using standard error code
> > semantics everywhere.
> >
> > Signed-off-by: Phillip Potter<phil@...lpotter.co.uk>
> > ---
> > drivers/staging/r8188eu/core/rtw_p2p.c | 19 ++++++++-----------
> > drivers/staging/r8188eu/os_dep/ioctl_linux.c | 12 +++++-------
> > 2 files changed, 13 insertions(+), 18 deletions(-)
>
>
> Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> # Edimax N150
Thank you for testing Philipp :-)
Regards,
Phil
Powered by blists - more mailing lists