linux-kernel - Re: [PATCH v4 4/4] dt-binding: perf: Add Amlogic DDR PMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <880842a1-a769-f228-7c91-5402e6d9391e@amlogic.com>
Date:   Fri, 5 Aug 2022 18:00:37 +0800
From:   Jiucheng Xu <jiucheng.xu@...ogic.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-amlogic@...ts.infradead.org>, <devicetree@...r.kernel.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Will Deacon <will@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH v4 4/4] dt-binding: perf: Add Amlogic DDR PMU


On 2022/8/5 16:21, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 05/08/2022 09:14, Jiucheng Xu wrote:
>> Add binding documentation for the Amlogic G12 series DDR
>> performance monitor unit.
>>
> Bindings go first in the series, before their implementation.
>
>> Signed-off-by: Jiucheng Xu <jiucheng.xu@...ogic.com>
>> ---
>> Changes v3 -> v4:
>>    - Fix "$id: relative path/filename doesn't match actual path or
>>      filename" warning
>>
>> Changes v2 -> v3:
>>    - Remove oneOf
>>    - Add descriptions
>>    - Fix compiling warning
>>
>> Changes v1 -> v2:
>>    - Rename file, from aml_ddr_pmu.yaml to amlogic,g12_ddr_pmu.yaml
>>    - Delete "model", "dmc_nr", "chann_nr" new properties
>>    - Fix compiling error
>> ---
>>   .../bindings/perf/amlogic,g12-ddr-pmu.yaml    | 52 +++++++++++++++++++
>>   MAINTAINERS                                   |  1 +
>>   2 files changed, 53 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml b/Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml
>> new file mode 100644
>> index 000000000000..4d018574ffd1
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml
>> @@ -0,0 +1,52 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/perf/amlogic,g12-ddr-pmu.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Amlogic G12 DDR performance monitor
>> +
>> +maintainers:
>> +  - Jiucheng Xu <jiucheng.xu@...ogic.com>
>> +
>> +description: |
>> +  Amlogic G12 series SoC integrate DDR bandwidth monitor.
>> +  A timer is inside and can generate interrupt when timeout.
>> +  The bandwidth is counted in the timer ISR. Different platform
>> +  has different subset of event format attribute.
>> +
>> +properties:
>> +  compatible:
>> +    items:
> You have only one item, so remove "items".
>
>> +      - enum:
>> +          - amlogic,g12b-ddr-pmu
>> +          - amlogic,g12a-ddr-pmu
>> +          - amlogic,sm1-ddr-pmu
>> +
>> +  reg:
>> +    items:
>> +      - description: Physical address of DMC bandwidth register
>> +          and size of the configuration address space.
> Skip obvious pieces, so only:
>
> description: DMC bandwidth register space
>
>> +      - description: Physical address of DMC PLL register and
>> +          size of the configuration address space.
> description: DMC PLL bandwidth register space
>
>
>> +
>> +  interrupts:
>> +    items:
>> +      - description: The IRQ of the inside timer timeout.
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +    ddr_pmu@...38000 {
> No underscores in node names, generic node names, so just "pmu".
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
>> +        compatible = "amlogic,g12a-ddr-pmu";
>> +        reg = <0xff638000 0x100
>> +               0xff638c00 0x100>;
> This is still not fixed. Binding says you have two items, but you
> declared here only one item.

Okay, I will change it as your comments.


> Best regards,
> Krzysztof
>
-- 
Thanks,
Jiucheng