linux-kernel - [PATCH 0/2] clk: gcc-sc8280xp: fix broken suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri,  5 Aug 2022 14:12:48 +0200
From:   Johan Hovold <johan+linaro@...nel.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        Johan Hovold <johan+linaro@...nel.org>
Subject: [PATCH 0/2] clk: gcc-sc8280xp: fix broken suspend

The Qualcomm PCIe driver currently does not implement suspend at all so
we need to mark the GDSCs as always-on to prevent genpd from disabling
them.

Similarly, the Qualcomm dwc3 USB suspend implementation is also
incomplete and the controller doesn't currently survive a suspend cycle
unless the GDSC is kept on. Note that this has nothing to with whether
wakeup is enabled or not (cf. [1]).

With these two workarounds, we have somewhat functional suspend on the
SC8280XP reference design and Lenovo Thinkpad X13s until the missing
driver support is in place (even USB remote wakeup works with [2]
applied).

Johan

[1] https://lore.kernel.org/all/20220804151001.23612-3-johan+linaro@kernel.org/
[2] https://lore.kernel.org/all/20220804151001.23612-1-johan+linaro@kernel.org/

Johan Hovold (2):
  clk: gcc-sc8280xp: keep PCIe power-domains always-on
  clk: gcc-sc8280xp: keep USB power-domains always-on

 drivers/clk/qcom/gcc-sc8280xp.c | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

-- 
2.35.1