linux-kernel - RE: [EXT] Re: [PATCH v1 3/3] firmware: imx: add imx-scu GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM9PR04MB82747C5078B14A22B98DB15D899E9@AM9PR04MB8274.eurprd04.prod.outlook.com>
Date:   Fri, 5 Aug 2022 12:31:09 +0000
From:   Shenwei Wang <shenwei.wang@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "brgl@...ev.pl" <brgl@...ev.pl>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [EXT] Re: [PATCH v1 3/3] firmware: imx: add imx-scu GPIO driver



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Friday, August 5, 2022 1:57 AM
> To: Shenwei Wang <shenwei.wang@....com>; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; linus.walleij@...aro.org; brgl@...ev.pl;
> shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> festevam@...il.com; dl-linux-imx <linux-imx@....com>
> Cc: devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> gpio@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> Subject: [EXT] Re: [PATCH v1 3/3] firmware: imx: add imx-scu GPIO driver
> 
> Caution: EXT Email
> 
> On 04/08/2022 20:49, Shenwei Wang wrote:
> > The SCU firmware on i.MX8 platforms provides a set of APIs to control
> > the GPIO PINs on the SCU domain. This patch implements the standard
> > GPIO driver interface to access those PINs on the SCU domain over the
> > SCU APIs.
> >
> > Signed-off-by: Shenwei Wang <shenwei.wang@....com>
> > ---
> >  drivers/firmware/imx/Kconfig        |   6 ++
> >  drivers/firmware/imx/Makefile       |   1 +
> >  drivers/firmware/imx/imx-scu-gpio.c | 139
> > ++++++++++++++++++++++++++++
> >  3 files changed, 146 insertions(+)
> >  create mode 100644 drivers/firmware/imx/imx-scu-gpio.c
> >
> > diff --git a/drivers/firmware/imx/Kconfig
> > b/drivers/firmware/imx/Kconfig index c027d99f2a59..484c13f3149a 100644
> > --- a/drivers/firmware/imx/Kconfig
> > +++ b/drivers/firmware/imx/Kconfig
> > @@ -28,3 +28,9 @@ config IMX_SCU_PD
> >       depends on IMX_SCU
> >       help
> >         The System Controller Firmware (SCFW) based power domain driver.
> > +
> > +config IMX_SCU_GPIO
> > +       def_bool y
> > +       depends on IMX_SCU
> > +       help
> > +         Say Y here to enable the imx8 gpio over SCFW MISC API
> 
> gpio driver go to drivers/gpio/

I was thinking to put the driver under drivers/gpio at the beginning too. Are there any requirements to put a driver under firmware directory?

Thanks,
Shenwei

> 
> Best regards,
> Krzysztof