linux-kernel - Re: [PATCH] ALSA: ice1712: remove redundant assignment to new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k07m260d.wl-tiwai@suse.de>
Date:   Fri, 05 Aug 2022 15:07:30 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: ice1712: remove redundant assignment to new

On Fri, 05 Aug 2022 14:04:39 +0200,
Colin Ian King wrote:
> 
> The variable new is initialized with a value but it is never read. It is
> being re-assigned a new value in every case path in the following switch
> statement. The assignment is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> sound/pci/ice1712/quartet.c:569:8: warning: Although the value stored
> to 'new' is used in the enclosing expression, the value is never actually
> read from 'new' [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Thanks, applied.


Takashi