linux-kernel - Re: [PATCH] drivers: android: binder: Fixed coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yu0cOiT3qKK/osGd@kroah.com>
Date:   Fri, 5 Aug 2022 15:33:46 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Alix Dixon <notdixon.alix@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: android: binder: Fixed coding style issue

On Fri, Aug 05, 2022 at 02:06:11PM +0100, Alix Dixon wrote:
> Fixed issue with comments on multiple lines not being aligned correctly + multiline comments not being on multiple lines

The irony of a changelog about not wrapping lines properly having an
inproper wrapped line is not lost on me :)

> 
> Signed-off-by: Alix Dixon <notdixon.alix@...il.com>

Any reason you didn't cc: all of the proper people that
scripts/get_maintainer.pl told you to cc?  This driver does have very
active maintainers.

> ---
>  drivers/android/binder.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index c964d7c8c..5a6da6765 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -5289,8 +5289,10 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>  	unsigned int size = _IOC_SIZE(cmd);
>  	void __user *ubuf = (void __user *)arg;
>  
> -	/*pr_info("binder_ioctl: %d:%d %x %lx\n",
> -			proc->pid, current->pid, cmd, arg);*/
> +	/*
> +	 * pr_info("binder_ioctl: %d:%d %x %lx\n",
> +	 *		proc->pid, current->pid, cmd, arg);
> +	 */

There's nothing wrong with the original code here.

Please fix up and resend.

thanks,

greg k-h