linux-kernel - Re: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vftx=uF4Y-PCutjVSFYEdT3PrDVu=Vc3AX+hJaKE80LoA@mail.gmail.com>
Date:   Fri, 5 Aug 2022 20:14:52 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Colin Foster <colin.foster@...advantage.com>
Cc:     linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Terry Bowman <terry.bowman@....com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Wolfram Sang <wsa@...nel.org>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Steen Hegelund <Steen.Hegelund@...rochip.com>,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Russell King <linux@...linux.org.uk>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Lee Jones <lee.jones@...aro.org>, katie.morris@...advantage.com
Subject: Re: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip
 via spi

On Fri, Aug 5, 2022 at 8:07 PM Colin Foster
<colin.foster@...advantage.com> wrote:
> On Fri, Aug 05, 2022 at 07:58:06PM +0200, Andy Shevchenko wrote:
> > On Fri, Aug 5, 2022 at 7:44 PM Colin Foster
> > <colin.foster@...advantage.com> wrote:
> > > On Tue, Aug 02, 2022 at 10:47:28PM -0700, Colin Foster wrote:

...

> > > > +int ocelot_chip_reset(struct device *dev)
> > >
> > > #include <linux/device.h>
> >
> > Nope,
> >
> > struct device;

...

> > > > +static int ocelot_spi_initialize(struct device *dev)
> > >
> > > #include <linux/device.h>
> >
> > Ditto.
>
> ocelot-spi.c uses devm_kzalloc, so that should still be included.
>
> ocelot-core.c uses dev_get_drvdata.
>
> So I think I still want the includes... but for different reasons.

Yes in this case.

-- 
With Best Regards,
Andy Shevchenko