linux-kernel - Re: [PATCH] ipc/util.c: Cleanup and improve sysvipc_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220805182637.bciu7eavmhxefsc7@offworld>
Date:   Fri, 5 Aug 2022 11:26:37 -0700
From:   Davidlohr Bueso <dave@...olabs.net>
To:     Manfred Spraul <manfred@...orfullife.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Eric W . Biederman" <ebiederm@...ssion.com>, 1vier1@....de,
        Waiman Long <longman@...hat.com>
Subject: Re: [PATCH] ipc/util.c: Cleanup and improve sysvipc_find_ipc(), V3

On Fri, 05 Aug 2022, Manfred Spraul wrote:

>sysvipc_find_ipc() can be simplified further:
>
>- It uses a for() loop to locate the next entry in the idr.
>  This can be replaced with idr_get_next().
>
>- It receives two parameters (pos - which is actually
>  an idr index and not a position, and new_pos, which
>  is really a position).
>  One parameter is sufficient.
>

Makes sense to me.

Acked-by: Davidlohr Bueso <dave@...olabs.net>