linux-kernel - [PATCH v3 net 1/4] geneve: do not use RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220805191906.9323-2-matthias.may@westermo.com>
Date:   Fri, 5 Aug 2022 21:19:03 +0200
From:   Matthias May <matthias.may@...termo.com>
To:     <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <roopa@...dia.com>,
        <eng.alaamohamedsoliman.am@...il.com>, <bigeasy@...utronix.de>,
        <saeedm@...dia.com>, <leon@...nel.org>, <roid@...dia.com>,
        <maord@...dia.com>, <lariel@...dia.com>, <vladbu@...dia.com>,
        <cmi@...dia.com>, <gnault@...hat.com>, <yoshfuji@...ux-ipv6.org>,
        <dsahern@...nel.org>, <linux-kernel@...r.kernel.org>,
        <bpf@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
        <nicolas.dichtel@...nd.com>, <eyal.birger@...il.com>,
        <jesse@...ira.com>, <linville@...driver.com>,
        <daniel@...earbox.net>, <hadarh@...lanox.com>,
        <ogerlitz@...lanox.com>, <willemb@...gle.com>,
        <martin.varghese@...ia.com>,
        Matthias May <matthias.may@...termo.com>
Subject: [PATCH v3 net 1/4] geneve: do not use RT_TOS for IPv6 flowlabel

According to Guillaume Nault RT_TOS should never be used for IPv6.

Quote:
RT_TOS() is an old macro used to interprete IPv4 TOS as described in
the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4
code, although, given the current state of the code, most of the
existing calls have no consequence.

But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS"
field to be interpreted the RFC 1349 way. There's no historical
compatibility to worry about.

Fixes: 3a56f86f1be6 ("geneve: handle ipv6 priority like ipv4 tos")
Acked-by: Guillaume Nault <gnault@...hat.com>
Signed-off-by: Matthias May <matthias.may@...termo.com>
---
v1 -> v2:
 - Fix spacing of "Fixes" tag.
 - Add missing CCs
v2 -> v3:
 - Add the info from the cover to the actual patch message (Guillaume Nault)
 - Correct length of fixes-tag from 13 to 12 characters (Guillaume Nault)
---
 drivers/net/geneve.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index 4c380c06f178..e1a4480e6f17 100644
--- a/drivers/net/geneve.c
+++ b/drivers/net/geneve.c
@@ -877,8 +877,7 @@ static struct dst_entry *geneve_get_v6_dst(struct sk_buff *skb,
 		use_cache = false;
 	}
 
-	fl6->flowlabel = ip6_make_flowinfo(RT_TOS(prio),
-					   info->key.label);
+	fl6->flowlabel = ip6_make_flowinfo(prio, info->key.label);
 	dst_cache = (struct dst_cache *)&info->dst_cache;
 	if (use_cache) {
 		dst = dst_cache_get_ip6(dst_cache, &fl6->saddr);
-- 
2.35.1