lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Aug 2022 23:53:17 +0300 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Mark Brown <broonie@...nel.org>, Aidan MacDonald <aidanmacdonald.0x0@...il.com>, linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org> Subject: [PATCH v1 1/5] regmap: mmio: Don't unprepare attached clock The commit eb4a219d19fd ("regmap: Skip clk_put for attached clocks when freeing context") oexcluded clk_put() call on regmap freeing. But the same is needed for clk_unprepare() since the regmap MMIO users should call regmap_mmio_detach_clk() which does unprepare the clock. Update the code accordingly, so neither clk_put() nor clk_unprepare() would be called for the attached clock. Fixes: eb4a219d19fd ("regmap: Skip clk_put for attached clocks when freeing context") Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> --- drivers/base/regmap/regmap-mmio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/base/regmap/regmap-mmio.c b/drivers/base/regmap/regmap-mmio.c index 71f16be7e717..e83a2c3ba95a 100644 --- a/drivers/base/regmap/regmap-mmio.c +++ b/drivers/base/regmap/regmap-mmio.c @@ -245,10 +245,9 @@ static void regmap_mmio_free_context(void *context) { struct regmap_mmio_context *ctx = context; - if (!IS_ERR(ctx->clk)) { + if (!IS_ERR(ctx->clk) && !ctx->attached_clk) { clk_unprepare(ctx->clk); - if (!ctx->attached_clk) - clk_put(ctx->clk); + clk_put(ctx->clk); } kfree(context); } -- 2.35.1
Powered by blists - more mailing lists