linux-kernel - Re: [PATCH 4/5] asus-wmi: Document many of the undocumented API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vdb3bs05iXccrb+Hp=VR-yVAifaY00JruH8i2Sv0QxGAA@mail.gmail.com>
Date:   Sat, 6 Aug 2022 12:00:45 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Luke D. Jones" <luke@...nes.dev>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/5] asus-wmi: Document many of the undocumented API

On Fri, Aug 5, 2022 at 10:21 AM Luke D. Jones <luke@...nes.dev> wrote:
>

Missed commit message.

> Signed-off-by: Luke D. Jones <luke@...nes.dev>

...

> +Date:          Dec 2022

I would be more optimistic here...

> +KernelVersion: 5.17

...and definitely this is the wrong version. I would suggest 6.0.

Both comments are applicable for other similar cases.

In case you are documenting new and old APIs, split this to two
patches with different dates and kernel versions. And commit messages
should be different.
-- 
With Best Regards,
Andy Shevchenko