linux-kernel - Re: [PATCH 0/5] asus-wmi: Add support for RGB keyboards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DPW6GR.725XHI643Y0N2@ljones.dev>
Date:   Sat, 06 Aug 2022 22:48:49 +1200
From:   Luke Jones <luke@...nes.dev>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/5] asus-wmi: Add support for RGB keyboards

I do agree. It's what I meant by prepped. I think I've addressed 
everything you've raised, so I'll leave it to bake a few days with my 
testing then submit new version on Tuesday (Hans please wait for v2).

Many thanks for your time taken to review this. I'm not an expert at C 
or the kernel by any stretch so reviews are critical for me. Also thank 
you for the link on git messages - I'll go through each patch and 
ensure they're better.

Kind regards,
Luke.

On Sat, Aug 6 2022 at 12:02:19 +0200, Andy Shevchenko 
<andy.shevchenko@...il.com> wrote:
> On Sat, Aug 6, 2022 at 11:33 AM Luke Jones <luke@...nes.dev> wrote:
>>  On Sat, Aug 6 2022 at 11:10:37 +0200, Andy Shevchenko
>>  <andy.shevchenko@...il.com> wrote:
> 
> ...
> 
>>  I do have another version already prepped
> 
> Hold on and try to address many more review comments. It seems the
> series needs much more work, otherwise it will be spam in the mailing
> list and demotivating reviewers to continue.
> 
> --
> With Best Regards,
> Andy Shevchenko