linux-kernel - Re: [PATCH] iio: Add names for function definition arguments.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 6 Aug 2022 17:18:39 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Joe Simmons-Talbott <joetalbott@...il.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: Add names for function definition arguments.

On Sun, 31 Jul 2022 12:01:20 -0400
Joe Simmons-Talbott <joetalbott@...il.com> wrote:

> As reported by checkpatch.pl add missing names for function definition
> arguments.
> 
> Signed-off-by: Joe Simmons-Talbott <joetalbott@...il.com>
Hi Joe,

I took this last week. Not sure why email didn't hit the list.

Thanks,

Jonathan

> ---
>  drivers/iio/industrialio-event.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
> index b5e059e15b0a..0e2056894965 100644
> --- a/drivers/iio/industrialio-event.c
> +++ b/drivers/iio/industrialio-event.c
> @@ -354,9 +354,10 @@ static int iio_device_add_event(struct iio_dev *indio_dev,
>  	enum iio_shared_by shared_by, const unsigned long *mask)
>  {
>  	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
> -	ssize_t (*show)(struct device *, struct device_attribute *, char *);
> -	ssize_t (*store)(struct device *, struct device_attribute *,
> -		const char *, size_t);
> +	ssize_t (*show)(struct device *dev, struct device_attribute *attr,
> +		char *buf);
> +	ssize_t (*store)(struct device *dev, struct device_attribute *attr,
> +		const char *buf, size_t len);
>  	unsigned int attrcount = 0;
>  	unsigned int i;
>  	char *postfix;