linux-kernel - Re: [PATCH] arch_topology: Silence early cacheinfo errors when non-existent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bfc7145-86d7-dc69-bfa0-f36c4c8b42d5@microchip.com>
Date:   Sat, 6 Aug 2022 18:27:33 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <f.fainelli@...il.com>, <linux-kernel@...r.kernel.org>
CC:     <sudeep.holla@....com>, <gregkh@...uxfoundation.org>,
        <rafael@...nel.org>, <ionela.voinescu@....com>
Subject: Re: [PATCH] arch_topology: Silence early cacheinfo errors when
 non-existent

On 06/08/2022 00:07, Florian Fainelli wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Architectures which do not have cacheinfo such as ARM 32-bit would spit
> out the following during boot:
> 
>  Early cacheinfo failed, ret = -2
> 
> Treat -ENOENT specifically to silence this error since it means that the
> platform does not support reporting its cache information.

Makes sense to me. Maybe we could soften the wording for failures on the
platforms that do support it since early cacheinfo failures (at least on
RISC-V) appear harmless - but that's for another day.
FWIW:
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

> 
> Fixes: 3fcbf1c77d08 ("arch_topology: Fix cache attributes detection in the CPU hotplug path")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  drivers/base/arch_topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
> index 0424b59b695e..eaa1b8d2d39d 100644
> --- a/drivers/base/arch_topology.c
> +++ b/drivers/base/arch_topology.c
> @@ -735,7 +735,7 @@ void update_siblings_masks(unsigned int cpuid)
>         int cpu, ret;
> 
>         ret = detect_cache_attributes(cpuid);
> -       if (ret)
> +       if (ret && ret != -ENOENT)
>                 pr_info("Early cacheinfo failed, ret = %d\n", ret);
> 
>         /* update core and thread sibling masks */
> --
> 2.25.1
>