linux-kernel - [intel-tdx:guest-hardening-rebased 11/23] arch/x86/coco/tdx/tdx.c:297:14: sparse: sparse: symbol 'tdx_write_msr' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202208061521.03fT4xpR-lkp@intel.com>
Date:   Sat, 6 Aug 2022 15:36:09 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
Subject: [intel-tdx:guest-hardening-rebased 11/23]
 arch/x86/coco/tdx/tdx.c:297:14: sparse: sparse: symbol 'tdx_write_msr' was
 not declared. Should it be static?

tree:   https://github.com/intel/tdx.git guest-hardening-rebased
head:   c170462888e1dab8e3e80c1c6e3708dd473ad1ed
commit: d1a7216a37f68b347a3622a0c8498134d5cb8970 [11/23] x86/tdx: Use direct paravirt call for wrmsrl
config: x86_64-randconfig-s022 (https://download.01.org/0day-ci/archive/20220806/202208061521.03fT4xpR-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel/tdx/commit/d1a7216a37f68b347a3622a0c8498134d5cb8970
        git remote add intel-tdx https://github.com/intel/tdx.git
        git fetch --no-tags intel-tdx guest-hardening-rebased
        git checkout d1a7216a37f68b347a3622a0c8498134d5cb8970
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/coco/tdx/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

sparse warnings: (new ones prefixed by >>)
>> arch/x86/coco/tdx/tdx.c:297:14: sparse: sparse: symbol 'tdx_write_msr' was not declared. Should it be static?

vim +/tdx_write_msr +297 arch/x86/coco/tdx/tdx.c

   296	
 > 297	void notrace tdx_write_msr(unsigned int msr, u32 low, u32 high)
   298	{
   299		struct tdx_hypercall_args args = {
   300			.r10 = TDX_HYPERCALL_STANDARD,
   301			.r11 = hcall_func(EXIT_REASON_MSR_WRITE),
   302			.r12 = msr,
   303			.r13 = (u64)high << 32 | low,
   304		};
   305	
   306		if (tdx_fast_tdcall_path_msr(msr))
   307			__tdx_hypercall(&args, 0);
   308		else
   309			native_write_msr(msr, low, high);
   310	}
   311	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp