linux-kernel - Re: [GIT PULL] hwmon updates for v5.20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yu+OzWv2JDbI89mW@gmail.com>
Date:   Sun, 7 Aug 2022 12:07:09 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] hwmon updates for v5.20


* Guenter Roeck <linux@...ck-us.net> wrote:

> Hi Linus,
> 
> I'll be traveling next week, so I am sending this pull request early,
> in the hope that there won't be a v5.19-rc9.
> 
> Please pull hwmon updates for Linux v5.20 from signed tag:
> 
>     git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-for-v5.20
> 
> Thanks,
> Guenter
> ------
> 
> The following changes since commit 88084a3df1672e131ddc1b4e39eeacfd39864acf:
> 
>   Linux 5.19-rc5 (2022-07-03 15:39:28 -0700)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git tags/hwmon-for-v5.20
> 
> for you to fetch changes up to cdbe34da01e32024e56fff5c6854a263a012d7ff:
> 
>   hwmon: (aquacomputer_d5next) Add support for Aquacomputer Quadro fan controller (2022-07-27 06:00:24 -0700)

>  drivers/hwmon/lm90.c                               | 2556 +++++++++++++-------

Just a quick build regression report, i386 allmodconfig fails to build due 
to a 'string overread' compiler warning in drivers/hwmon/lm90.o:

  # make ARCH=i386 allmodconfig
  # make ARCH=i386 drivers/hwmon/lm90.o

  CALL    scripts/atomic/check-atomics.sh
  CALL    scripts/checksyscalls.sh
  CC [M]  drivers/hwmon/lm90.o
In file included from ./include/linux/string.h:253,
                 from ./arch/x86/include/asm/page_32.h:22,
                 from ./arch/x86/include/asm/page.h:14,
                 from ./arch/x86/include/asm/thread_info.h:12,
                 from ./include/linux/thread_info.h:60,
                 from ./arch/x86/include/asm/preempt.h:7,
                 from ./include/linux/preempt.h:78,
                 from ./include/linux/rcupdate.h:27,
                 from ./include/linux/rculist.h:11,
                 from ./include/linux/pid.h:5,
                 from ./include/linux/sched.h:14,
                 from ./include/linux/ratelimit.h:6,
                 from ./include/linux/dev_printk.h:16,
                 from ./include/linux/device.h:15,
                 from drivers/hwmon/lm90.c:99:
  In function ‘__fortify_strlen’,
      inlined from ‘strlcpy’ at ./include/linux/fortify-string.h:159:10,
      inlined from ‘lm90_detect’ at drivers/hwmon/lm90.c:2550:2:
  ./include/linux/fortify-string.h:50:33: error: ‘__builtin_strlen’ reading 1 or more bytes from a region of size 0 [-Werror=stringop-overread]
     50 | #define __underlying_strlen     __builtin_strlen
        |                                 ^
  ./include/linux/fortify-string.h:141:24: note: in expansion of macro ‘__underlying_strlen’
    141 |                 return __underlying_strlen(p);
        |                        ^~~~~~~~~~~~~~~~~~~
  cc1: all warnings being treated as errors
  make[2]: *** [scripts/Makefile.build:249: drivers/hwmon/lm90.o] Error 1

It's a build warning upgraded to a build error by CONFIG_WERROR=y, it 
normally looks like this:

                 from drivers/hwmon/lm90.c:99:
  In function ‘__fortify_strlen’,
      inlined from ‘strlcpy’ at ./include/linux/fortify-string.h:159:10,
      inlined from ‘lm90_detect’ at drivers/hwmon/lm90.c:2550:2:
  ./include/linux/fortify-string.h:50:33: warning: ‘__builtin_strlen’ reading 1 or more bytes from a region of size 0 [-Wstringop-overread]

Thanks,

	Ingo