linux-kernel - Re: [PATCH v1 1/4] pwm: sysfs: Switch to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220807085610.ahbxorztafdkol53@pengutronix.de>
Date:   Sun, 7 Aug 2022 10:56:10 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>
Subject: Re: [PATCH v1 1/4] pwm: sysfs: Switch to DEFINE_SIMPLE_DEV_PM_OPS()
 and pm_sleep_ptr()

Hello,

On Sun, Aug 07, 2022 at 12:23:28AM +0300, Andy Shevchenko wrote:
> Using these newer macros allows the compiler to remove the unused
> structure and functions when !CONFIG_PM_SLEEP + removes the need to
> mark pm functions __maybe_unused.

Tested on ARCH=arm allmodconfig: No change in the binary (as expected I
think). When disabling PM_SLEEP the resulting change of this patch looks
as follows:

	add/remove: 0/1 grow/shrink: 0/0 up/down: 0/-92 (-92)
	Function                                     old     new   delta
	pwm_class_pm_ops                              92       -     -92
	Total: Before=5213, After=5121, chg -1.76%

Looks like a quest to convert all SIMPLE_DEV_PM_OPS users to
DEFINE_SIMPLE_DEV_PM_OPS.

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)