linux-kernel - Re: [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Aug 2022 20:37:42 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Jia He <justin.he@....com>, Len Brown <lenb@...nel.org>,
        James Morse <james.morse@....com>,
        Tony Luck <tony.luck@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Richter <rric@...nel.org>,
        Shuai Xue <xueshuai@...ux.alibaba.com>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:EDAC-CORE" <linux-edac@...r.kernel.org>,
        Toshi Kani <toshi.kani@....com>
Subject: Re: [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv
 register

+ Toshi.

On Mon, Aug 08, 2022 at 08:17:58PM +0200, Rafael J. Wysocki wrote:
> This effectively makes EDAC depend on GHES which may not be always
> valid AFAICS.

Yes, and this has been getting on my nerves since forever.

The GHES code which does collect all those errors *forces* the
registration of an EDAC module which does only the reporting.

Which cannot be any more backwards.

What should happen is, GHES inits and starts working on the errors.
Then, at some point later, ghes_edac loads and starts reporting whatever
it gets. If there's no EDAC module, it doesn't report them. The same way
MCA works.

That's it.

And then ghes_edac can be made a normal module again and we can get rid
of this insanity.

Jia, willing to try it?

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette