linux-kernel - Re: [PATCH] platform/chrome: cros_ec: Expose suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 8 Aug 2022 13:54:19 -0700
From:   Prashant Malani <pmalani@...omium.org>
To:     Evan Green <evgreen@...omium.org>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Rajat Jain <rajatja@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Tinghan Shen <tinghan.shen@...iatek.com>,
        Tzung-Bi Shih <tzungbi@...nel.org>,
        chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_ec: Expose suspend_timeout in debugfs

Hi Evan,

On Fri, Aug 5, 2022 at 3:17 PM Evan Green <evgreen@...omium.org> wrote:
>
> diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c
> index 0dbceee87a4b1a..530378bd4359dd 100644
> --- a/drivers/platform/chrome/cros_ec_debugfs.c
> +++ b/drivers/platform/chrome/cros_ec_debugfs.c
> @@ -470,6 +470,9 @@ static int cros_ec_debugfs_probe(struct platform_device *pd)
>         debugfs_create_x32("last_resume_result", 0444, debug_info->dir,
>                            &ec->ec_dev->last_resume_result);
>
> +       debugfs_create_u16("suspend_timeout", 0664, debug_info->dir,
> +                          &ec->ec_dev->suspend_timeout);

Can we call this "suspend_timeout_ms" instead? That makes it clear what the
units being used are.

BR,

- Prashant