linux-kernel - [PATCH] remoteproc: rcar_rproc: silince address space sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Aug 2022 09:16:09 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>,
        Julien Massot <julien.massot@....bzh>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        <linux-remoteproc@...r.kernel.org>
CC:     Geert Uytterhoeven <geert+renesas@...der.be>,
        <linux-kernel@...r.kernel.org>, <rmk+kernel@...linux.org.uk>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        kernel test robot <lkp@...el.com>
Subject: [PATCH] remoteproc: rcar_rproc: silince address space sparse warning

Fix sparse warnings,
   drivers/remoteproc/st_remoteproc.c:98:12: sparse: sparse: incorrect type in assignment (different address spaces) @@
	   expected void *va @@     got void [noderef] __iomem * @@
   drivers/remoteproc/st_remoteproc.c:98:12: sparse:     expected void *va
   drivers/remoteproc/st_remoteproc.c:98:12: sparse:     got void [noderef] __iomem *
   ...
   drivers/remoteproc/st_remoteproc.c:114:20: sparse:     expected void volatile [noderef] __iomem *io_addr
   drivers/remoteproc/st_remoteproc.c:114:20: sparse:     got void *va

Add __iomem to io address space 'va' to fix it.

Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
---
note: the commit d803336abdbc "(ARM: mm: kill unused runtime hook arch_iounmap())"
won't introduce the warning, but lkp report issue to me many times,
let's fix it.

 drivers/remoteproc/rcar_rproc.c | 2 +-
 include/linux/remoteproc.h      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/rcar_rproc.c b/drivers/remoteproc/rcar_rproc.c
index aa86154109c7..e3363a4cde0a 100644
--- a/drivers/remoteproc/rcar_rproc.c
+++ b/drivers/remoteproc/rcar_rproc.c
@@ -22,7 +22,7 @@ static int rcar_rproc_mem_alloc(struct rproc *rproc,
 				 struct rproc_mem_entry *mem)
 {
 	struct device *dev = &rproc->dev;
-	void *va;
+	void __iomem *va;
 
 	dev_dbg(dev, "map memory: %pa+%zx\n", &mem->dma, mem->len);
 	va = ioremap_wc(mem->dma, mem->len);
diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
index 7c943f0a2fc4..c0c950cf7d72 100644
--- a/include/linux/remoteproc.h
+++ b/include/linux/remoteproc.h
@@ -330,7 +330,7 @@ struct rproc;
  * @alloc: specific memory allocator function
  */
 struct rproc_mem_entry {
-	void *va;
+	void __iomem *va;
 	bool is_iomem;
 	dma_addr_t dma;
 	size_t len;
-- 
2.35.3